[#299] improvement: Make config type of RSS_STORAGE_TYPE as enum #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zuston @jerqi @xianjingfeng I'd like to learn more about your thought on this PR if you are available and any comments and suggestions would be appreciated. I'm sorry for any inconvenience that I may have caused. |
|
@cchung100m Master CI failed. I revert this pr. Could you rebase the latest master and raise a new pr? |
jerqi
added a commit
that referenced
this pull request
Aug 7, 2023
|
Hi @jerqi Thanks for the notification. I will submit the PR again based on latest master branch. BTW, do we have any ideas that why the Master CI failed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zuston @jerqi @xianjingfeng
Any comments and suggestions would be appreciated if you are available, thank you.
What changes were proposed in this pull request?
improvement: Make config type of
RSS_STORAGE_TYPEinRssBaseConfas enumWhy are the changes needed?
Fix: #299
Does this PR introduce any user-facing change?
No.
How was this patch tested?
current UT and integration testing