-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Make config type of RSS_STORAGE_TYPE as enum #299
Comments
is it change to something like this? public static final ConfigOption RSS_STORAGE_TYPE = ConfigOptions |
Yes, do you want to submit a PR? |
yes i will fix this |
I looked this a bit. I thought this requires a good amount of refactoring. For example you might need to move |
### What changes were proposed in this pull request? improvement: Make config type of `RSS_STORAGE_TYPE` in `RssBaseConf` as enum ### Why are the changes needed? Fix: #299 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? current UT and integration testing
### What changes were proposed in this pull request? improvement: Make config type of `RSS_STORAGE_TYPE` in `RssBaseConf` as enum ### Why are the changes needed? Fix: #299 and re-submit for #1106 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? current UT and integration testing
Code of Conduct
Search before asking
What would you like to be improved?
Make config type of
RSS_STORAGE_TYPE
inRssBaseConf
as enumHow should we improve?
The enum type of config option is introduced in #199, follow this PR to fix the storage type config
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: