[#1114] feat: introduce hdfs host as the total_hadoop_write_data metric label #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
============================================
+ Coverage 54.10% 55.48% +1.38%
- Complexity 2547 2562 +15
============================================
Files 386 368 -18
Lines 21901 19635 -2266
Branches 1815 1826 +11
============================================
- Hits 11850 10895 -955
+ Misses 9352 8106 -1246
+ Partials 699 634 -65
... and 40 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Should we create an issue for this pr? |
zuston
changed the title
Done |
|
ptal @jerqi |
I'm not familiar with |
advancedxy
reviewed
Aug 8, 2023
| @@ -125,7 +126,7 @@ public class ShuffleServerMetrics { | |||
| public static Counter.Child counterTotalReadTime; | |||
| public static Counter.Child counterTotalFailedWrittenEventNum; | |||
| public static Counter.Child counterTotalDroppedEventNum; | |||
| public static Counter.Child counterTotalHadoopWriteDataSize; | |||
| public static Counter counterTotalHadoopWriteDataSize; | |||
There was a problem hiding this comment.
would you move this field to L162 - L165, and grouped together?
public static Counter counterRemoteStorageTotalWrite;
public static Counter counterRemoteStorageRetryWrite;
public static Counter counterRemoteStorageFailedWrite;
public static Counter counterRemoteStorageSuccessWrite;
|
LGTM, except one minor comment. |
smallzhongfeng
previously approved these changes
Aug 9, 2023
advancedxy
approved these changes
Aug 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce the hdfs host as the total_hadoop_write_data metric label
Why are the changes needed?
We will write apps of different businesses apps into different HDFS.
For further iterative optimization, we need to expose the write capacity of
different HDFS to evaluate the total write capacity of different business lines.
Does this PR introduce any user-facing change?
Yes. More metrics are exposed.
How was this patch tested?