[WIP][RFC] Blockid hide long #1724
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Hides the
longblock id behind an interface.Why are the changes needed?
This hides implementation details behind a meaningful interface. The
longrepresentation of a block id is not use in many places but currently visible everywhere. This allows to replace the block id representation in the future without touching much code.This is based on #1723 (block id set) and turns the set of longs into a true set of
BlockIds.Ultimately, this would allow to rework the structure of block id without touching many files (#1621).
Fix: # (issue)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit and integration tests.