[IMPROVEMENT] Introduce the enumType in ConfigOptions #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
reviewed
Sep 5, 2022
common/src/test/java/org/apache/uniffle/common/config/ConfigOptionTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
============================================
- Coverage 58.41% 57.21% -1.21%
+ Complexity 1273 1199 -74
============================================
Files 158 149 -9
Lines 8448 7965 -483
Branches 784 754 -30
============================================
- Hits 4935 4557 -378
+ Misses 3260 3166 -94
+ Partials 253 242 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
cc @smallzhongfeng , the pr is useful for your pr #192. |
Good job, this is helpful for my pr. After you review this PR, I will repair my current pr. |
jerqi
approved these changes
Sep 5, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce the enumType in ConfigOptions
Why are the changes needed?
When I want to extend the zstd compression type in uniffle, I found we lack the enum class for configOptions.
And I think it will be used for users to specify the concrete implementation in some pluggable class.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UTs.