Fix NPE in WriteBufferManager.addRecord #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=========================================
Coverage 60.10% 60.11%
- Complexity 1413 1414 +1
=========================================
Files 175 175
Lines 9082 9084 +2
Branches 872 873 +1
=========================================
+ Hits 5459 5461 +2
Misses 3331 3331
Partials 292 292
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zuston
reviewed
Nov 3, 2022
| if (value != null) { | ||
| serializeStream.writeValue(value, ClassTag$.MODULE$.apply(value.getClass())); | ||
| } else { | ||
| serializeStream.writeValue(null, null); |
There was a problem hiding this comment.
Is it consistent with spark logic?
There was a problem hiding this comment.
Is it consistent with spark logic?
There is no special handling of null values in spark, but when the value is null, scala infers that the ClassTag is scala.reflect.ManifestFactory#Null
zuston
approved these changes
Nov 3, 2022
kaijchen
pushed a commit
that referenced
this pull request
Nov 12, 2022
### What changes were proposed in this pull request? To handle the NPE of record value to be consistent with Spark ### Why are the changes needed? Fix NPE: ``` 22/11/03 03:36:08 ERROR Executor: Exception in task 4.0 in stage 1.0 (TID 5) java.lang.NullPointerException at org.apache.spark.shuffle.writer.WriteBufferManager.addRecord(WriteBufferManager.java:116) at org.apache.spark.shuffle.writer.RssShuffleWriter.write(RssShuffleWriter.java:152) at org.apache.spark.shuffle.ShuffleWriteProcessor.write(ShuffleWriteProcessor.scala:59) at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:99) at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:52) at org.apache.spark.scheduler.Task.run(Task.scala:131) at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:497) at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1439) at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:500) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UTs
zuston
added a commit
that referenced
this pull request
Feb 27, 2023
…alue is null (#666) ### What changes were proposed in this pull request? keep consistent with vanilla spark when key or value is null ### Why are the changes needed? Fix: #665 The PR of #296 has fixed the bug of NPE of value. But in some cases of production, the key also could be null. So this corner case also should keep consistent with vanilla spark. And to prevent this logic from reverting, the corresponding tests have been attached. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Unit tests
zuston
added a commit
that referenced
this pull request
Feb 27, 2023
…alue is null (#666) ### What changes were proposed in this pull request? keep consistent with vanilla spark when key or value is null ### Why are the changes needed? Fix: #665 The PR of #296 has fixed the bug of NPE of value. But in some cases of production, the key also could be null. So this corner case also should keep consistent with vanilla spark. And to prevent this logic from reverting, the corresponding tests have been attached. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Unit tests
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…y or value is null (apache#666) ### What changes were proposed in this pull request? keep consistent with vanilla spark when key or value is null ### Why are the changes needed? Fix: apache#665 The PR of apache#296 has fixed the bug of NPE of value. But in some cases of production, the key also could be null. So this corner case also should keep consistent with vanilla spark. And to prevent this logic from reverting, the corresponding tests have been attached. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix NPE:
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?