-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#665] fix(client): keep consistent with vanilla spark when key or value is null #666
Conversation
…y or value is null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zuston , This should be a fix. We should cherry-pick and commit to branch 0.7.
Yes. How to cherry pick in github web? |
You can use git client in your local machine. |
Directly push or submit PR? |
If there is no conflict, it's ok to push directly. |
Got it. |
…alue is null (#666) ### What changes were proposed in this pull request? keep consistent with vanilla spark when key or value is null ### Why are the changes needed? Fix: #665 The PR of #296 has fixed the bug of NPE of value. But in some cases of production, the key also could be null. So this corner case also should keep consistent with vanilla spark. And to prevent this logic from reverting, the corresponding tests have been attached. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Unit tests
…y or value is null (apache#666) ### What changes were proposed in this pull request? keep consistent with vanilla spark when key or value is null ### Why are the changes needed? Fix: apache#665 The PR of apache#296 has fixed the bug of NPE of value. But in some cases of production, the key also could be null. So this corner case also should keep consistent with vanilla spark. And to prevent this logic from reverting, the corresponding tests have been attached. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Unit tests
What changes were proposed in this pull request?
keep consistent with vanilla spark when key or value is null
Why are the changes needed?
Fix: #665
The PR of #296 has fixed the bug of NPE of value. But in some cases of production, the key also could be null. So this corner case also should keep consistent with vanilla spark.
And to prevent this logic reverting, the corresponding tests have been attached.
Does this PR introduce any user-facing change?
No.
How was this patch tested?