Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Improvement] Skip blocks when read from memory (#294)" #403

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

xianjingfeng
Copy link
Member

This reverts commit 55191c4.

What changes were proposed in this pull request?

Revert #294

Why are the changes needed?

BlockId is discontinuous, so BLOCKID_RANGE is not a good choice to filter memory data

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #403 (9668101) into master (ddf8384) will increase coverage by 0.05%.
The diff coverage is 18.75%.

@@             Coverage Diff              @@
##             master     #403      +/-   ##
============================================
+ Coverage     58.51%   58.56%   +0.05%     
+ Complexity     1616     1604      -12     
============================================
  Files           195      194       -1     
  Lines         11069    10984      -85     
  Branches        977      961      -16     
============================================
- Hits           6477     6433      -44     
+ Misses         4209     4174      -35     
+ Partials        383      377       -6     
Impacted Files Coverage Δ
.../java/org/apache/hadoop/mapreduce/RssMRConfig.java 23.07% <ø> (ø)
...pache/hadoop/mapreduce/task/reduce/RssShuffle.java 0.00% <ø> (ø)
.../java/org/apache/spark/shuffle/RssSparkConfig.java 93.75% <ø> (-0.13%) ⬇️
...e/uniffle/client/factory/ShuffleClientFactory.java 0.00% <0.00%> (ø)
...client/request/CreateShuffleReadClientRequest.java 0.00% <0.00%> (ø)
...rg/apache/uniffle/client/util/RssClientConfig.java 0.00% <ø> (ø)
.../java/org/apache/uniffle/common/util/RssUtils.java 60.58% <ø> (-7.00%) ⬇️
...pache/uniffle/server/ShuffleServerGrpcService.java 0.81% <ø> (+<0.01%) ⬆️
.../org/apache/uniffle/server/ShuffleTaskManager.java 77.22% <0.00%> (ø)
...uniffle/storage/factory/ShuffleHandlerFactory.java 0.00% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xianjingfeng

@jerqi jerqi merged commit 45e600c into apache:master Dec 12, 2022
@xianjingfeng xianjingfeng deleted the revert_294 branch March 1, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants