Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpotBugs] Remove unread protected field in Checker #520

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Jan 30, 2023

What changes were proposed in this pull request?

  1. Remove unread protected field in Checker.
  2. Remove SpotBugs exclusion URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD.

Why are the changes needed?

Reduce SpotBugs exceptions.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@kaijchen kaijchen changed the title [Refactor] Change abstract class Checker to interface [SpotBugs] Ignore URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD in Checker Jan 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Merging #520 (85d451d) into master (b80972c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #520      +/-   ##
============================================
- Coverage     59.76%   59.76%   -0.01%     
  Complexity     1768     1768              
============================================
  Files           205      205              
  Lines         11531    11530       -1     
  Branches       1033     1033              
============================================
- Hits           6892     6891       -1     
  Misses         4233     4233              
  Partials        406      406              
Impacted Files Coverage Δ
...c/main/java/org/apache/uniffle/server/Checker.java 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaijchen kaijchen changed the title [SpotBugs] Ignore URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD in Checker [SpotBugs] Remove unread protected field in Checker Jan 30, 2023
@advancedxy advancedxy merged commit 6367b36 into apache:master Jan 31, 2023
@advancedxy
Copy link
Contributor

Thanks @kaijchen

@kaijchen kaijchen deleted the unused branch January 31, 2023 07:21
@kaijchen
Copy link
Contributor Author

Ref #532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants