Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] test: address unchecked conversions in tests #624

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

Address unchecked conversions in tests.

Why are the changes needed?

Reduce warnings in build log.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@kaijchen kaijchen changed the title [MINOR] test: address unchecked conversions [MINOR] test: address unchecked conversions in tests Feb 17, 2023
@kaijchen kaijchen marked this pull request as draft February 17, 2023 09:42
@kaijchen
Copy link
Contributor Author

#623 should be merged first.

@kaijchen kaijchen marked this pull request as ready for review February 22, 2023 07:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #624 (b153c23) into master (8b347a2) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #624      +/-   ##
============================================
+ Coverage     62.83%   62.85%   +0.01%     
- Complexity     1798     1799       +1     
============================================
  Files           202      202              
  Lines         10491    10491              
  Branches       1052     1052              
============================================
+ Hits           6592     6594       +2     
+ Misses         3551     3550       -1     
+ Partials        348      347       -1     
Impacted Files Coverage Δ
...he/uniffle/server/storage/LocalStorageManager.java 87.57% <0.00%> (+1.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 4fd9cad into apache:master Feb 28, 2023
advancedxy pushed a commit to advancedxy/incubator-uniffle that referenced this pull request Mar 21, 2023
### What changes were proposed in this pull request?

Address unchecked conversions in tests.

### Why are the changes needed?

Reduce warnings in build log.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI.
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this pull request Apr 5, 2023
### What changes were proposed in this pull request?

Address unchecked conversions in tests.

### Why are the changes needed?

Reduce warnings in build log.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants