[#627] fix(operator): support specifying custom ports #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
changed the title
advancedxy
reviewed
Feb 17, 2023
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator.go
Show resolved
Hide resolved
wangao1236
force-pushed
the
feat-support-custom-ports
branch
from
9251f59
to
115faea
Compare
advancedxy
previously approved these changes
Feb 20, 2023
wangao1236
force-pushed
the
feat-support-custom-ports
branch
from
115faea
to
b6f773e
Compare
|
Should this pr be included in 0.7? @advancedxy |
It's better to include this one since it's a bug fix. also cc @zuston |
advancedxy
approved these changes
Feb 20, 2023
It's OK for me. |
|
Thanks @wangao1236, merging this. And if possible, would you cherry-pick this pr to branch-0.7? |
If there are no conficts, you can commit directly. |
jerqi
pushed a commit
that referenced
this pull request
Feb 21, 2023
### What changes were proposed in this pull request? Set coordinator/shuffler server's container port to the fields of RSS spec ### Why are the changes needed? Fix #627. ### Does this PR introduce _any_ user-facing change? For RSS cluster admin, they can set custom ports for shuffle servers and coordinators. ### How was this patch tested? Manually verified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set coordinator/shuffler server's container port to the fields of RSS spec
Why are the changes needed?
Fix #627.
Does this PR introduce any user-facing change?
For RSS cluster admin, they can set custom ports for shuffle servers and coordinators.
How was this patch tested?
Manually verified.