Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#580] chore(ci): disable parallel build in maven #631

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Feb 20, 2023

What changes were proposed in this pull request?

Disable parallel build in maven

Why are the changes needed?

Error:  Error occurred in starting fork, check output in log
Error:  Process Exit Code: 1
Error:  Crashed tests:
Error:  org.apache.uniffle.server.ShuffleServerTest

https://github.com/apache/incubator-uniffle/actions/runs/4220729609/jobs/7327285796#step:6:1317

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@kaijchen
Copy link
Contributor Author

Closed in favor of #628.

@kaijchen kaijchen closed this Feb 20, 2023
@advancedxy
Copy link
Contributor

Actually, I'm prefer to merge this pr rather than the #628

@advancedxy
Copy link
Contributor

Do you want to re-open this pr and get this merged?

@kaijchen kaijchen reopened this Feb 20, 2023
@kaijchen
Copy link
Contributor Author

Do you want to re-open this pr and get this merged?

OK, re-opened.

@kaijchen kaijchen marked this pull request as ready for review February 20, 2023 08:53
@zuston
Copy link
Member

zuston commented Feb 20, 2023

+1. Many flaky tests are caused by this problem.

Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. pending CI pass

@kaijchen kaijchen merged commit cdf4f06 into apache:master Feb 20, 2023
@kaijchen kaijchen deleted the no-parrallel-ci branch February 20, 2023 09:44
@kaijchen kaijchen mentioned this pull request Feb 20, 2023
13 tasks
kaijchen pushed a commit that referenced this pull request Feb 20, 2023
### What changes were proposed in this pull request?

Fix a typo in build.yml

### Why are the changes needed?

Follow up of #631

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Verified by another github action.
jerqi pushed a commit that referenced this pull request Feb 21, 2023
### What changes were proposed in this pull request?

Disable parallel build in maven

### Why are the changes needed?

CI crashed.

```
Error:  Error occurred in starting fork, check output in log
Error:  Process Exit Code: 1
Error:  Crashed tests:
Error:  org.apache.uniffle.server.ShuffleServerTest
```

https://github.com/apache/incubator-uniffle/actions/runs/4220729609/jobs/7327285796#step:6:1317

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI.
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this pull request Apr 5, 2023
### What changes were proposed in this pull request?

Fix a typo in build.yml

### Why are the changes needed?

Follow up of apache#631

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Verified by another github action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants