-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#580] chore(ci): disable parallel build in maven #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed in favor of #628. |
Actually, I'm prefer to merge this pr rather than the #628 |
Do you want to re-open this pr and get this merged? |
OK, re-opened. |
+1. Many flaky tests are caused by this problem. |
advancedxy
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. pending CI pass
13 tasks
This was referenced Feb 20, 2023
kaijchen
pushed a commit
that referenced
this pull request
Feb 20, 2023
### What changes were proposed in this pull request? Fix a typo in build.yml ### Why are the changes needed? Follow up of #631 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Verified by another github action.
jerqi
pushed a commit
that referenced
this pull request
Feb 21, 2023
### What changes were proposed in this pull request? Disable parallel build in maven ### Why are the changes needed? CI crashed. ``` Error: Error occurred in starting fork, check output in log Error: Process Exit Code: 1 Error: Crashed tests: Error: org.apache.uniffle.server.ShuffleServerTest ``` https://github.com/apache/incubator-uniffle/actions/runs/4220729609/jobs/7327285796#step:6:1317 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI.
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
### What changes were proposed in this pull request? Fix a typo in build.yml ### Why are the changes needed? Follow up of apache#631 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Verified by another github action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Disable parallel build in maven
Why are the changes needed?
https://github.com/apache/incubator-uniffle/actions/runs/4220729609/jobs/7327285796#step:6:1317
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.