Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#626][FOLLOWUP] chore(ci): fix typo in build.yml #633

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

advancedxy
Copy link
Contributor

What changes were proposed in this pull request?

Fix a typo in build.yml

Why are the changes needed?

Follow up of #631

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Verified by another github action.

@advancedxy
Copy link
Contributor Author

@kaijchen sorry, please help review this pr.

@advancedxy
Copy link
Contributor Author

#617 the latest action in this pr runs kubernetes related pipeline.

@codecov-commenter
Copy link

Codecov Report

Merging #633 (6beeff3) into master (ffa26b4) will increase coverage by 2.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #633      +/-   ##
============================================
+ Coverage     60.90%   63.19%   +2.29%     
  Complexity     1799     1799              
============================================
  Files           214      200      -14     
  Lines         12381    10410    -1971     
  Branches       1042     1042              
============================================
- Hits           7541     6579     -962     
+ Misses         4437     3488     -949     
+ Partials        403      343      -60     
Impacted Files Coverage Δ
deploy/kubernetes/operator/pkg/utils/util.go
...y/kubernetes/operator/pkg/webhook/inspector/pod.go
...oy/kubernetes/operator/pkg/controller/util/util.go
deploy/kubernetes/operator/pkg/utils/config.go
deploy/kubernetes/operator/pkg/utils/rss.go
...oy/kubernetes/operator/pkg/utils/shufflerserver.go
...eploy/kubernetes/operator/pkg/utils/coordinator.go
...bernetes/operator/pkg/controller/controller/rss.go
...tor/pkg/controller/sync/coordinator/coordinator.go
...rnetes/operator/pkg/webhook/inspector/inspector.go
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@advancedxy
Copy link
Contributor Author

ping @kaijchen

@kaijchen kaijchen changed the title [#626][FOLLOWUP] fix: typo in build.yml [#626][FOLLOWUP] chore(ci): fix typo in build.yml Feb 20, 2023
@kaijchen kaijchen merged commit 350aa5a into master Feb 20, 2023
@kaijchen kaijchen deleted the advancedxy-patch-1 branch February 20, 2023 15:24
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this pull request Apr 5, 2023
### What changes were proposed in this pull request?

Fix a typo in build.yml

### Why are the changes needed?

Follow up of apache#631

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Verified by another github action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants