[#630] feat(client): Disable the localShuffleReader by default in Spark3 client #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Isn't this a user facing change? |
Yes |
advancedxy
reviewed
Feb 21, 2023
|
LGTM, left one minor comment. |
advancedxy
approved these changes
Feb 21, 2023
|
Thanks @advancedxy . Merged |
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…in Spark3 client (apache#636) ### What changes were proposed in this pull request? Disable the localShuffleReader by default in Spark3 client ### Why are the changes needed? in `RssShuffleManager`, the local shuffle reader should be disabled by default (`spark.sql.adaptive.localShuffleReader.enabled=false`), as it would cause too many random small IOs and network connections with shuffle servers. ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Don't need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Disable the localShuffleReader by default in Spark3 client
Why are the changes needed?
in
RssShuffleManager, the local shuffle reader should be disabled by default (spark.sql.adaptive.localShuffleReader.enabled=false), as it would cause too many random small IOs and network connections with shuffle servers.Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Don't need