Skip to content

Commit

Permalink
[#630] feat(client): Disable the localShuffleReader by default in Spa…
Browse files Browse the repository at this point in the history
…rk3 client (#636)

### What changes were proposed in this pull request?

Disable the localShuffleReader by default in Spark3 client

### Why are the changes needed?

in `RssShuffleManager`, the local shuffle reader should be disabled by default (`spark.sql.adaptive.localShuffleReader.enabled=false`), as it would cause too many random small IOs and network connections with shuffle servers.

### Does this PR introduce _any_ user-facing change?

Yes

### How was this patch tested?

Don't need
  • Loading branch information
zuston authored Feb 21, 2023
1 parent c45c187 commit 85b7b3b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ public RssShuffleManager(SparkConf conf, boolean isDriver) {
// External shuffle service is not supported when using remote shuffle service
sparkConf.set("spark.shuffle.service.enabled", "false");
LOG.info("Disable external shuffle service in RssShuffleManager.");
sparkConf.set("spark.sql.adaptive.localShuffleReader.enabled", "false");
LOG.info("Disable local shuffle reader in RssShuffleManager.");
taskToSuccessBlockIds = Maps.newConcurrentMap();
taskToFailedBlockIds = Maps.newConcurrentMap();
// for non-driver executor, start a thread for sending shuffle data to shuffle server
Expand Down
5 changes: 5 additions & 0 deletions docs/client_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ and Continuous partition assignment mechanism.
# Default value is 1.0, used to estimate task concurrency, how likely is this part of the resource between spark.dynamicAllocation.minExecutors and spark.dynamicAllocation.maxExecutors to be allocated
--conf spark.rss.estimate.task.concurrency.dynamic.factor=1.0
```

Since v0.8.0, `RssShuffleManager` would disable local shuffle reader(`set spark.sql.adaptive.localShuffleReader.enabled=false`) optimization by default.

Local shuffle reader as its name indicates is suitable and optimized for spark's external shuffle service, and shall not be used for remote shuffle service. It would cause many random small IOs and network connections with Uniffle's shuffle server

### Deploy MapReduce Client Plugin

1. Add client jar to the classpath of each NodeManager, e.g., <HADOOP>/share/hadoop/mapreduce/
Expand Down

0 comments on commit 85b7b3b

Please sign in to comment.