-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#647] fix: Multiple coordinator produce conflicts when they delect the same file #648
Conversation
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
============================================
+ Coverage 60.89% 62.90% +2.00%
- Complexity 1798 1801 +3
============================================
Files 214 202 -12
Lines 12381 10496 -1885
Branches 1042 1052 +10
============================================
- Hits 7539 6602 -937
+ Misses 4438 3547 -891
+ Partials 404 347 -57
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two minor comments
...org/apache/uniffle/coordinator/strategy/storage/LowestIOSampleCostSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/uniffle/coordinator/strategy/storage/AppBalanceSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
addressed comments. |
Thanks, merged this into master |
This is a fix, I will merge this pr to branch-0.7, too. cc @zuston |
What changes were proposed in this pull request?
Add coordinator's id to the file which Coordinator delect.
Why are the changes needed?
Fix #647
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT