Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Multiple Coordinator call method detectStorage #647

Closed
3 tasks done
jerqi opened this issue Feb 22, 2023 · 0 comments · Fixed by #648
Closed
3 tasks done

[Bug] Multiple Coordinator call method detectStorage #647

jerqi opened this issue Feb 22, 2023 · 0 comments · Fixed by #648

Comments

@jerqi
Copy link
Contributor

jerqi commented Feb 22, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

If we have multiple coordinators, they detect the same path, we delete and create the same file, they will influence each other.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
jerqi added a commit to jerqi/incubator-uniffle that referenced this issue Feb 22, 2023
@jerqi
[apache#647] fix: Multiple coordinator delect the same file
359644d
@jerqi jerqi mentioned this issue Feb 22, 2023
Merged
advancedxy pushed a commit that referenced this issue Feb 23, 2023
@jerqi
[#647] fix: Multiple coordinator produce conflicts when they delect t…
d1a3bd1 
…he same file (#648)

### What changes were proposed in this pull request?
Add coordinator's id to the file which Coordinator delect.

### Why are the changes needed?
Fix #647

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
UT
jerqi added a commit that referenced this issue Feb 23, 2023
@jerqi
[#647] fix: Multiple coordinator produce conflicts when they delect t…
0cdfd35 
…he same file (#648)

### What changes were proposed in this pull request?
Add coordinator's id to the file which Coordinator delect.

### Why are the changes needed?
Fix #647

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
UT
advancedxy added a commit to advancedxy/incubator-uniffle that referenced this issue Feb 24, 2023
@advancedxy
[apache#647][FOLLOWUP] set coordinator id before ApplicationMaster
45a7d10
@advancedxy advancedxy mentioned this issue Feb 24, 2023
Merged
jerqi pushed a commit that referenced this issue Feb 24, 2023
@advancedxy
[#647][FOLLOWUP] set coordinator id before ApplicationMaster (#654)
b98f9fd 
### What changes were proposed in this pull request?
set coordinator id before ApplicationMaster construction, otherwise uuid is used for ` AbstractSelectStorageStrategy`

### Why are the changes needed?
Follow up of #647

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Manually verified
jerqi pushed a commit that referenced this issue Feb 24, 2023
@advancedxy @jerqi
[#647][FOLLOWUP] set coordinator id before ApplicationMaster (#654)
69311c3 
### What changes were proposed in this pull request?
set coordinator id before ApplicationMaster construction, otherwise uuid is used for ` AbstractSelectStorageStrategy`

### Why are the changes needed?
Follow up of #647

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Manually verified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jerqi