[#612] test: cleanup shuffleServer instance for each test #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Is there any other occurrences(tests) to stop shuffle server for each test? |
It depends on whether the test cases use exclusive or shareable shuffle servers. |
advancedxy
approved these changes
Feb 27, 2023
OK. Let's fix that when other test cases have similar problem. |
|
Thanks @advancedxy |
|
@zuston Could you cherrypick and commit to branch 0.7 branch, too. |
zuston
added a commit
that referenced
this pull request
Mar 7, 2023
### What changes were proposed in this pull request? Cleanup shuffleServer instance for each test ### Why are the changes needed? When digging into the root cause of #612, I found some problems that the shuffle server instance should be released after each test case is finished. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Don't need
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…he#658) ### What changes were proposed in this pull request? Cleanup shuffleServer instance for each test ### Why are the changes needed? When digging into the root cause of apache#612, I found some problems that the shuffle server instance should be released after each test case is finished. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Don't need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cleanup shuffleServer instance for each test
Why are the changes needed?
When digging into the root cause of #612, I found some problems that the shuffle server instance should be released after each test case is finished.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Don't need