Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test: ShuffleTaskManagerTest#removeShuffleDataWithHdfsTest #612

Open
2 of 3 tasks
zuston opened this issue Feb 16, 2023 · 1 comment
Open
2 of 3 tasks

Flaky Test: ShuffleTaskManagerTest#removeShuffleDataWithHdfsTest #612

zuston opened this issue Feb 16, 2023 · 1 comment

Comments

@zuston
Copy link
Member

zuston commented Feb 16, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the flaky test

Error:  Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 85.858 s <<< FAILURE! - in org.apache.uniffle.server.ShuffleTaskManagerTest
Error:  removeShuffleDataWithHdfsTest  Time elapsed: 15.048 s  <<< ERROR!
java.lang.RuntimeException: Shuffle data commit timeout for 10000 ms
	at org.apache.uniffle.server.ShuffleTaskManager.commitShuffle(ShuffleTaskManager.java:259)
	at org.apache.uniffle.server.ShuffleTaskManagerTest.removeShuffleDataWithHdfsTest(ShuffleTaskManagerTest.java:427)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

Actions URL

https://github.com/apache/incubator-uniffle/actions/runs/4191298244/jobs/7265939805

Parent issue

#1733

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zuston
Copy link
Member Author

zuston commented Feb 25, 2023

Detailed info:

2023-02-16 06:57:00,663 INFO  [main] buffer.ShuffleBufferManager (ShuffleBufferManager.java:pickFlushedShuffle(500)) - Finish flush pick with 67 bytes
SLF4J: Failed toString() invocation on an object of type [org.apache.uniffle.server.ShuffleDataFlushEvent]
Reported exception:
java.lang.NullPointerException
	at org.apache.uniffle.server.ShuffleDataFlushEvent.toString(ShuffleDataFlushEvent.java:163)
	at org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:277)
	at org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:249)
	at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:211)
	at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:161)
	at org.slf4j.helpers.MessageFormatter.format(MessageFormatter.java:124)
	at org.slf4j.impl.Log4jLoggerAdapter.error(Log4jLoggerAdapter.java:516)
	at org.apache.uniffle.server.ShuffleFlushManager.flushToFile(ShuffleFlushManager.java:186)
	at org.apache.uniffle.server.ShuffleFlushManager.processEvent(ShuffleFlushManager.java:157)
	at org.apache.uniffle.server.ShuffleFlushManager.lambda$processNextEvent$0(ShuffleFlushManager.java:148)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)

zuston added a commit to zuston/incubator-uniffle that referenced this issue Feb 25, 2023
zuston added a commit that referenced this issue Feb 27, 2023
### What changes were proposed in this pull request?

Cleanup shuffleServer instance for each test

### Why are the changes needed?

When digging into the root cause of #612, I found some problems that the shuffle server instance should be released after each test case is finished.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Don't need
zuston added a commit that referenced this issue Mar 7, 2023
### What changes were proposed in this pull request?

Cleanup shuffleServer instance for each test

### Why are the changes needed?

When digging into the root cause of #612, I found some problems that the shuffle server instance should be released after each test case is finished.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Don't need
advancedxy pushed a commit to advancedxy/incubator-uniffle that referenced this issue Mar 21, 2023
…he#658)

### What changes were proposed in this pull request?

Cleanup shuffleServer instance for each test

### Why are the changes needed?

When digging into the root cause of apache#612, I found some problems that the shuffle server instance should be released after each test case is finished.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Don't need
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant