[#585] feat(netty): Add MaxDirectMemorySize option for shuffle Server #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smallzhongfeng Could you help me review this pr? |
|
thanks @zuston @smallzhongfeng |
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…Server (apache#690) ### What changes were proposed in this pull request? Add MaxDirectMemorySize option for shuffle Server. It will be convenient for Netty. ### Why are the changes needed? Fix: apache#585 ### Does this PR introduce _any_ user-facing change? Yes. I will add the entire document of rss-env.sh in the future. ### How was this patch tested? Manual test Co-authored-by: roryqi <roryqi@tencent.com>
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…Server (apache#690) ### What changes were proposed in this pull request? Add MaxDirectMemorySize option for shuffle Server. It will be convenient for Netty. ### Why are the changes needed? Fix: apache#585 ### Does this PR introduce _any_ user-facing change? Yes. I will add the entire document of rss-env.sh in the future. ### How was this patch tested? Manual test Co-authored-by: roryqi <roryqi@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add MaxDirectMemorySize option for shuffle Server. It will be convenient for Netty.
Why are the changes needed?
Fix: #585
Does this PR introduce any user-facing change?
Yes. I will add the entire document of rss-env.sh in the future.
How was this patch tested?
Manual test