Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#585] fix: avoid unbound variable errors in start-shuffle-server.sh #696

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

zuston
Copy link
Member

@zuston zuston commented Mar 8, 2023

What changes were proposed in this pull request?

If unset the var of MAX_DIRECT_MEMORY_SIZE, the error of unbound variable will be thrown when executing the start-shuffle-server.sh

Why are the changes needed?

Use the ${xxx:-} to check its existence. refer to : https://bnikolic.co.uk/blog/bash-unbound-variable

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Tested in production env

@zuston zuston requested a review from jerqi March 8, 2023 09:52
@zuston
Copy link
Member Author

zuston commented Mar 8, 2023

cc @jerqi

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #696 (e3f0de8) into master (00454c1) will increase coverage by 2.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #696      +/-   ##
============================================
+ Coverage     60.80%   63.06%   +2.26%     
- Complexity     1840     1841       +1     
============================================
  Files           221      207      -14     
  Lines         12648    10684    -1964     
  Branches       1062     1062              
============================================
- Hits           7690     6738     -952     
+ Misses         4552     3601     -951     
+ Partials        406      345      -61     
Impacted Files Coverage Δ
deploy/kubernetes/operator/pkg/utils/rss.go
...pkg/controller/sync/shuffleserver/shuffleserver.go
...tor/pkg/controller/sync/coordinator/coordinator.go
deploy/kubernetes/operator/pkg/webhook/manager.go
deploy/kubernetes/operator/pkg/utils/config.go
...bernetes/operator/pkg/controller/controller/rss.go
...y/kubernetes/operator/pkg/webhook/inspector/pod.go
...rnetes/operator/pkg/webhook/inspector/inspector.go
...oy/kubernetes/operator/pkg/utils/shufflerserver.go
deploy/kubernetes/operator/pkg/utils/util.go
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi
Copy link
Contributor

jerqi commented Mar 9, 2023

Merged . Thanks @zuston

@jerqi jerqi merged commit 4f23f3d into master Mar 9, 2023
@kaijchen kaijchen deleted the zuston-patch-1 branch March 10, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants