[MINOR] test: fix tempdir leak in KerberizedHdfs tests #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaijchen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
============================================
+ Coverage 60.49% 62.81% +2.31%
- Complexity 1846 1850 +4
============================================
Files 228 215 -13
Lines 12744 10785 -1959
Branches 1067 1064 -3
============================================
- Hits 7710 6775 -935
+ Misses 4625 3660 -965
+ Partials 409 350 -59 see 30 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@zuston please cherry-pick this to branch-0.7 after it's merged. |
jerqi
pushed a commit
that referenced
this pull request
Mar 15, 2023
### What changes were proposed in this pull request? Use JUnit 5 managed `@TempDir` in `KerberizedHdfs` test. ### Why are the changes needed? The tempdir created by `KerberizedHdfs` is leaking. It may cause test failures in some condition. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Before: ```console $ mvn test -Dtest=HadoopFilesystemProviderTest ... $ find . -name 'serverKS.jks' ./common/target/tmp/kerberizedDfsBaseDir1821275617120252168/serverKS.jks ``` After: ```console $ mvn test -Dtest=HadoopFilesystemProviderTest ... $ find . -name 'serverKS.jks' ```
|
Merge to master & branch 0.7. |
|
Thanks @jerqi for the review. |
|
@kaijchen The test fail [ERROR] org.apache.uniffle.common.filesystem.HadoopFilesystemProviderTest Time elapsed: 1.896 s <<< ERROR! java.lang.Exception: java.io.FileNotFoundException: /Users/roryqi/Downloads/apache-uniffle-0.7.0-incubating-src/common/target/tmp/junit1553702532156578735/serverKS.jks (No such file or directory) I revert this pr. The tests passed. |
|
@jerqi OK, please revert this. I'll look into it later. |
jerqi
added a commit
that referenced
this pull request
Mar 16, 2023
jerqi
added a commit
that referenced
this pull request
Mar 16, 2023
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
### What changes were proposed in this pull request? Use JUnit 5 managed `@TempDir` in `KerberizedHdfs` test. ### Why are the changes needed? The tempdir created by `KerberizedHdfs` is leaking. It may cause test failures in some condition. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Before: ```console $ mvn test -Dtest=HadoopFilesystemProviderTest ... $ find . -name 'serverKS.jks' ./common/target/tmp/kerberizedDfsBaseDir1821275617120252168/serverKS.jks ``` After: ```console $ mvn test -Dtest=HadoopFilesystemProviderTest ... $ find . -name 'serverKS.jks' ```
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…e#721)" (apache#732) This reverts commit 37d7659.
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Mar 26, 2023
### What changes were proposed in this pull request? Use JUnit 5 managed `@TempDir` in `KerberizedHdfs` test. ### Why are the changes needed? The tempdir created by `KerberizedHdfs` is leaking. It may cause test failures in some condition. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Before: ```console $ mvn test -Dtest=HadoopFilesystemProviderTest ... $ find . -name 'serverKS.jks' ./common/target/tmp/kerberizedDfsBaseDir1821275617120252168/serverKS.jks ``` After: ```console $ mvn test -Dtest=HadoopFilesystemProviderTest ... $ find . -name 'serverKS.jks' ```
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Mar 26, 2023
…e#721)" (apache#732) This reverts commit 37d7659.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use JUnit 5 managed
@TempDirinKerberizedHdfstest.Why are the changes needed?
The tempdir created by
KerberizedHdfsis leaking.It may cause test failures in some condition.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Before:
After: