[#625] improvement: Package sun.security.krb5 is not visible in Java 11 and 17. #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
============================================
+ Coverage 60.60% 62.91% +2.30%
- Complexity 1849 1859 +10
============================================
Files 229 217 -12
Lines 12749 10897 -1852
Branches 1064 1073 +9
============================================
- Hits 7727 6856 -871
+ Misses 4611 3686 -925
+ Partials 411 355 -56
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zuston
approved these changes
Mar 15, 2023
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
… Java 11 and 17. (apache#726) ### What changes were proposed in this pull request? Try remove `sun.security.krb5.Config.refresh();` ### Why are the changes needed? `sun.security.krb5` is not visible in Java 11 and 17. We need to compile on JDK11 and JDK17 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test verification. Co-authored-by: slfan1989 <louj1988@@>
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
… Java 11 and 17. (apache#726) ### What changes were proposed in this pull request? Try remove `sun.security.krb5.Config.refresh();` ### Why are the changes needed? `sun.security.krb5` is not visible in Java 11 and 17. We need to compile on JDK11 and JDK17 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test verification. Co-authored-by: slfan1989 <louj1988@@>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Try remove
sun.security.krb5.Config.refresh();Why are the changes needed?
sun.security.krb5is not visible in Java 11 and 17. We need to compile on JDK11 and JDK17Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test verification.