[#752] refactor: replace RuntimeException with RssException #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
============================================
+ Coverage 60.72% 62.81% +2.08%
- Complexity 1901 1902 +1
============================================
Files 238 225 -13
Lines 13017 11067 -1950
Branches 1091 1091
============================================
- Hits 7905 6952 -953
+ Misses 4674 3737 -937
+ Partials 438 378 -60
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…ache#753) ### What changes were proposed in this pull request? Replace raw use of `RuntimeException` with `RssException` in src/main. Enable spotbugs check: [THROWS_METHOD_THROWS_RUNTIMEEXCEPTION][1] [1]: https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#throws-method-intentionally-throws-runtimeexception-throws-method-throws-runtimeexception ### Why are the changes needed? Fix: apache#752 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested by spotbugs and existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace raw use of
RuntimeExceptionwithRssExceptionin src/main.Enable spotbugs check: THROWS_METHOD_THROWS_RUNTIMEEXCEPTION
Why are the changes needed?
Fix: #752
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested by spotbugs and existing tests.