[Improvement] Replace raw use of RuntimeException #752
Comments
jerqi
pushed a commit
that referenced
this issue
Mar 22, 2023
### What changes were proposed in this pull request? Replace raw use of `RuntimeException` with `RssException` in src/main. Enable spotbugs check: [THROWS_METHOD_THROWS_RUNTIMEEXCEPTION][1] [1]: https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#throws-method-intentionally-throws-runtimeexception-throws-method-throws-runtimeexception ### Why are the changes needed? Fix: #752 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested by spotbugs and existing tests.
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this issue
Apr 5, 2023
…ache#753) ### What changes were proposed in this pull request? Replace raw use of `RuntimeException` with `RssException` in src/main. Enable spotbugs check: [THROWS_METHOD_THROWS_RUNTIMEEXCEPTION][1] [1]: https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#throws-method-intentionally-throws-runtimeexception-throws-method-throws-runtimeexception ### Why are the changes needed? Fix: apache#752 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested by spotbugs and existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
What would you like to be improved?
Raw use of
RuntimeExceptionis difficult to catch.Because other runtime Exceptions will be catched as well.
We should avoid using raw
RuntimeException.How should we improve?
The simple solution is to replace
RuntimeExceptionwithRssException.The best solution is to replace
RuntimeExceptionwith specific exception.We might need to create new Exception class for more expressive.
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: