Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#389] Improvement: Make codec to be a singleton. #840

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

tobehardest
Copy link
Contributor

What changes were proposed in this pull request?

Codec will be created for many times. We should make codec to be a singleton. I make codec to be a singleton.

Why are the changes needed?

Fix: #389

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT

@tobehardest tobehardest changed the title [Improvement] Make codec to be a singleton. [#389 ] Improvement: Make codec to be a singleton. Apr 25, 2023
@smallzhongfeng smallzhongfeng changed the title [#389 ] Improvement: Make codec to be a singleton. [#389] Improvement: Make codec to be a singleton. Apr 25, 2023
@smallzhongfeng
Copy link
Contributor

PTAL @zuston

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #840 (41b00a4) into master (4a17a58) will increase coverage by 2.32%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #840      +/-   ##
============================================
+ Coverage     57.09%   59.42%   +2.32%     
- Complexity     2144     2147       +3     
============================================
  Files           321      301      -20     
  Lines         15648    13295    -2353     
  Branches       1243     1243              
============================================
- Hits           8934     7900    -1034     
+ Misses         6206     4960    -1246     
+ Partials        508      435      -73     
Impacted Files Coverage Δ
...a/org/apache/uniffle/common/compression/Codec.java 100.00% <100.00%> (ø)
...rg/apache/uniffle/common/compression/Lz4Codec.java 85.71% <100.00%> (+2.38%) ⬆️
...g/apache/uniffle/common/compression/NoOpCodec.java 100.00% <100.00%> (ø)
...apache/uniffle/common/compression/SnappyCodec.java 57.89% <100.00%> (+2.33%) ⬆️
...g/apache/uniffle/common/compression/ZstdCodec.java 75.86% <100.00%> (+0.86%) ⬆️

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks all

@jerqi jerqi merged commit c58110f into apache:master Apr 25, 2023
@jerqi
Copy link
Contributor

jerqi commented Apr 25, 2023

Merged to master.

@jerqi
Copy link
Contributor

jerqi commented Apr 27, 2023

Do you have a Wechat acount? If you want to our Uniffle Wechat group, you can scan
Screenshot_2023-04-27-19-23-30-802_com tencent mm

@tobehardest tobehardest deleted the codec_singleton branch April 28, 2023 12:57
@tobehardest
Copy link
Contributor Author

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Make codec to be a singleton.
4 participants