[Improvement] Make codec to be a singleton.

[xianjingfeng]

Code of Conduct

• I agree to follow this project's Code of Conduct

Search before asking

• I have searched in the issues and found no similar issues.

What would you like to be improved?

Codec will be created for many times. We should make codec to be a singleton.

incubator-uniffle/common/src/main/java/org/apache/uniffle/common/compression/Codec.java

Lines 29 to 40 in 8847ece

	public static Codec newInstance(RssConf rssConf) {
	Type type = rssConf.get(COMPRESSION_TYPE);
	switch (type) {
	case ZSTD:
	return new ZstdCodec(rssConf.get(ZSTD_COMPRESSION_LEVEL));
	case SNAPPY:
	return new SnappyCodec();
	case NOOP:
	return new NoOpCodec();
	case LZ4:
	default:
	return new Lz4Codec();

How should we improve?

Make codec to be a singleton.

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[jerqi]

Will it be thread safe?

[xianjingfeng]

Will it be thread safe?

Yes. In fact, the underlying codec is also a singleton.

[jerqi]

cc @zuston

[zuston]

The zstd and snappy codec looks OK of singleton. But LZ4Codec looks unsupported.

[xianjingfeng]

But LZ4Codec looks unsupported.

It seems that LZ4Codec is also singleton

[tobehardest]

I'm a newbie and I want to try to solve this problem, is it possible?

[jerqi]

I assign this issue to you. You can have a try.

[jerqi]

The zstd and snappy codec looks OK of singleton. But LZ4Codec looks unsupported.

lz4/lz4-java#82 Lz4 is thread safe. So it could be an singleton.

[jerqi]

I'm a newbie and I want to try to solve this problem, is it possible?

Do you need any help from me?

[tobehardest]

I'm a newbie and I want to try to solve this problem, is it possible?

Do you need any help from me?
Maybe i need.

[jerqi]

I'm a newbie and I want to try to solve this problem, is it possible?

Do you need any help from me?
Maybe i need.

@tobehardest Do you know Singleton pattern? There is an example https://github.com/apache/incubator-uniffle/blob/master/internal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleManagerClientFactory.java . You can refer to it.

The document is also useful for newbie. https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md