[#895] improvement: Rename Hdfs*.java to Hadoop*.java to support other Hadoop FS-compatible distributed filesystem #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder Signed-off-by: jiafu zhang <jiafu.zhang@intel.com>
jerqi
reviewed
May 23, 2023
| HDFS(4), | ||
| LOCALFILE_HDFS(6), | ||
| HADOOP(4), | ||
| LOCALFILE_HADOOP(6), |
There was a problem hiding this comment.
Could we avoid modifying the config option? Because this is a incompatible change. Or we should make this change compatible. We should make old config option effective.
There was a problem hiding this comment.
Could we avoid modifying the config option? Because this is a incompatible change. Or we should make this change compatible. We should make old config option effective.
make sense. Let me rollback that part.
…op FS-compatible distributed filesystem Signed-off-by: jiafu zhang <jiafu.zhang@intel.com>
…op FS-compatible distributed filesystem Signed-off-by: Jiafu Zhang <jiafu.zhang@intel.com>
…op FS-compatible distributed filesystem Signed-off-by: Jiafu Zhang <jiafu.zhang@intel.com>
…op FS-compatible distributed filesystem Signed-off-by: Jiafu Zhang <jiafu.zhang@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
============================================
+ Coverage 55.22% 57.07% +1.84%
- Complexity 2197 2200 +3
============================================
Files 333 313 -20
Lines 16444 14089 -2355
Branches 1306 1307 +1
============================================
- Hits 9081 8041 -1040
+ Misses 6851 5607 -1244
+ Partials 512 441 -71
... and 27 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
changed the title
jerqi
changed the title
jerqi
approved these changes
May 24, 2023
jerqi
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In server and storage modules, there are many classes prefixed with Hdfs which use Hadoop FS API and are thus impl agnostic, not depending on specific Hdfs impl. So, it's better to rename them to Hadoop* so that we can support other Hadoop FS compatible distributed filesystem by extending existing classes. It'll make code look more naturally.
There may be some slight differences among different Hadoop FS impls, like hadoop-daos not have a dedicated thread for reading and writing data, which is different from hdfs. Thus, we don't need to close outputstream at each flush to FS.
Why are the changes needed?
Fix: #895
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI passed.