[Improvement] Rename Hdfs*.java to Hadoop*.java to support other Hadoop FS-compatible distributed filesystem #895
Comments
|
@advancedxy @jerqi does it look reasonable for you? |
|
Sounds good |
|
OK for me. |
|
SGTM. |
jerqi
pushed a commit
that referenced
this issue
May 24, 2023
…r Hadoop FS-compatible distributed filesystem (#898) ### What changes were proposed in this pull request? In server and storage modules, there are many classes prefixed with Hdfs which use Hadoop FS API and are thus impl agnostic, not depending on specific Hdfs impl. So, it's better to rename them to Hadoop* so that we can support other Hadoop FS compatible distributed filesystem by extending existing classes. It'll make code look more naturally. There may be some slight differences among different Hadoop FS impls, like [hadoop-daos](https://github.com/daos-stack/daos/tree/master/src/client/java/hadoop-daos) not have a dedicated thread for reading and writing data, which is different from hdfs. Thus, we don't need to close outputstream at each flush to FS. ### Why are the changes needed? Fix: #895 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI passed. Signed-off-by: jiafu zhang <jiafu.zhang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
What would you like to be improved?
In server and storage modules, there are many classes prefixed with Hdfs which use Hadoop FS API and are thus impl agnostic, not depending on specific Hdfs impl. So, it's better to rename them to Hadoop* so that we can support other Hadoop FS compatible distributed filesystem by extending existing classes. It'll make code look more naturally.
There may be some slight differences among different Hadoop FS impls, like hadoop-daos not have a dedicated thread for reading and writing data, which is different from hdfs. Thus, we don't need to close outputstream at each flush to FS.
How should we improve?
Just rename the class names.
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: