[#933] fix: incorrect metric grpc_server_connection_number #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
============================================
- Coverage 55.34% 55.32% -0.02%
+ Complexity 2273 2272 -1
============================================
Files 344 344
Lines 16982 16983 +1
Branches 1349 1349
============================================
- Hits 9398 9396 -2
- Misses 7038 7041 +3
Partials 546 546
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Jun 7, 2023
| @@ -37,7 +37,9 @@ public Attributes transportReady(Attributes transportAttrs) { | |||
| } | |||
|
|
|||
| public void transportTerminated(Attributes transportAttrs) { | |||
| grpcMetrics.decGauge(GRPC_SERVER_CONNECTION_NUMBER_KEY); | |||
| if (transportAttrs != null) { | |||
There was a problem hiding this comment.
in which case, the transportAttrs is null?
There was a problem hiding this comment.
When handshake fails.
grpc/grpc-java#7625 (comment)
There was a problem hiding this comment.
We can use telnet to trigger the problem. Just close it when telnet connect to rpc port.
zuston
approved these changes
Jun 7, 2023
| @@ -37,7 +37,9 @@ public Attributes transportReady(Attributes transportAttrs) { | |||
| } | |||
|
|
|||
| public void transportTerminated(Attributes transportAttrs) { | |||
| grpcMetrics.decGauge(GRPC_SERVER_CONNECTION_NUMBER_KEY); | |||
| if (transportAttrs != null) { | |||
There was a problem hiding this comment.
Do you check when the transportAttrs will be null?
|
Merged, thanks all. |
@xianjingfeng Should we merge this pr to branch 0.7? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix incorrect metric grpc_server_connection_number
Why are the changes needed?
Fix: #933
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT