Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect metric grpc_server_connection_number #933

Closed
3 tasks done
xianjingfeng opened this issue Jun 7, 2023 · 0 comments · Fixed by #934
Closed
3 tasks done

[Bug] Incorrect metric grpc_server_connection_number #933

xianjingfeng opened this issue Jun 7, 2023 · 0 comments · Fixed by #934

Comments

@xianjingfeng
Copy link
Member

xianjingfeng commented Jun 7, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

Sometimes, metric grpc_server_connection_number will be less than 0.

grpc/grpc-java#7625 (comment)

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
xianjingfeng added a commit that referenced this issue Jun 8, 2023
### What changes were proposed in this pull request?
Fix incorrect metric grpc_server_connection_number

### Why are the changes needed?
Fix: #933

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
Existing UT
jerqi pushed a commit that referenced this issue Jun 9, 2023
### What changes were proposed in this pull request?

Fix incorrect metric grpc_server_connection_number

### Why are the changes needed?

Fix: #933 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant