[#933][0.7] fix: incorrect metric grpc_server_connection_number #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianjingfeng
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.7 #941 +/- ##
================================================
- Coverage 60.76% 60.76% -0.01%
Complexity 1796 1796
================================================
Files 214 214
Lines 12385 12386 +1
Branches 1048 1048
================================================
Hits 7526 7526
- Misses 4454 4455 +1
Partials 405 405
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zuston
approved these changes
Jun 9, 2023
jerqi
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix incorrect metric grpc_server_connection_number
Why are the changes needed?
Fix: #933
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT