Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* [WEEX-240] [android] feature update for weexsandbox #1088

Merged
merged 4 commits into from Mar 27, 2018

Conversation

@yuhun-alibaba
Copy link
Contributor

@yuhun-alibaba yuhun-alibaba commented Mar 27, 2018

Weex SandBox

yuhun-alibaba and others added 4 commits Mar 14, 2018
     1. every page will has a runtime context independent of other page
     2. At the beginning of js, will use // {"framework" : "Rax"} or // {"framework" : "Vue"} to distinguish type
     3. if page type is neither Rax nor Vue, will use global context runtime
     4. delete some usless code and opt build tools, trim so
@weex-bot
Copy link

@weex-bot weex-bot commented Mar 27, 2018

Fails
🚫 Running your Dangerfile has Failed

Danger has errored

Error: TypeError

TypeError: Cannot read property 'code' of null
    at Object.<anonymous> (./dangerfile-android.js:98:126)
    at Runtime._execModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:446:13)
    at Runtime.requireModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:294:14)
    at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:136:33
    at ensureCleanDangerfile (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:176:5)
    at Object.<anonymous> (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:135:21)
    at step (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:32:23)
    at Object.next (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:13:53)
    at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:7:71
    at __awaiter (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:3:12)

Generated by 🚫 dangerJS

Copy link
Member

@misakuo misakuo left a comment

ok

@yuhun-alibaba yuhun-alibaba changed the title Apache master multicontext * [WEEX-240] [android] feature update for weexsandbox Mar 27, 2018
@asfgit asfgit merged commit 45ec92c into apache:master Mar 27, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants