This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
heron-merge #2636
Merged
heron-merge #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s) converting method.
…nceId Keep The Same With Others
# Conflicts: # ios/sdk/WeexSDK.xcodeproj/project.pbxproj
# Conflicts: # ios/sdk/WeexSDK.xcodeproj/project.pbxproj # ios/sdk/WeexSDK/Sources/Utility/WXVersion.m
# Conflicts: # android/playground/app/build.gradle # android/playground/app/src/main/java/com/alibaba/weex/WXApplication.java # android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
zshshr
requested review from
Darin726,
gubaojian,
wqyfavor and
YorkShen
as code owners
Generated by 🚫 dangerJS |
lucky-chen
reviewed
Jul 2, 2019
| } | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
shouldn't delete, use for preinit
lucky-chen
reviewed
Jul 2, 2019
| @@ -1493,11 +1480,13 @@ public void run() { | |||
| } | |||
|
|
|||
| WXModuleManager.createDomModule(instance); | |||
| instance.getApmForInstance().onStage(WXInstanceApm.KEY_PAGE_STAGES_LOAD_BUNDLE_START); | |||
lucky-chen
reviewed
Jul 2, 2019
| post(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| long start = System.currentTimeMillis(); | ||
| instance.getApmForInstance().onStage(WXInstanceApm.KEY_PAGE_STAGES_LOAD_BUNDLE_START); |
There was a problem hiding this comment.
shouldn't mv position,mv back
lucky-chen
reviewed
Jul 2, 2019
| @@ -861,7 +869,6 @@ private void renderInternal(String pageName, | |||
| } | |||
| if (isPreInitMode()){ | |||
| getApmForInstance().onStage(WXInstanceApm.KEY_PAGE_STAGES_LOAD_BUNDLE_START); | |||
| WXBridgeManager.getInstance().loadJsBundleInPreInitMode(getInstanceId(),template.getContent()); | |||
There was a problem hiding this comment.
shouldn't remove for preinit mode
YorkShen
suggested changes
Jul 2, 2019
| @@ -1519,6 +1532,9 @@ public void onViewAppear(){ | |||
|
|
|||
|
|
|||
| public void onCreateFinish() { | |||
| if(mHasCreateFinish){ | |||
There was a problem hiding this comment.
This will cause onViewAppear never invoked
YorkShen
suggested changes
Jul 2, 2019
katherine95s
pushed a commit
to katherine95s/incubator-weex
that referenced
this pull request
Jul 4, 2019
katherine95s
pushed a commit
to katherine95s/incubator-weex
that referenced
this pull request
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heron-merge