Iceberg ITs #219
Merged
Iceberg ITs #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@the-other-tim-brown Please take a look. |
| @@ -255,14 +280,11 @@ private Object generateRandomValueForType( | |||
| return LocalDate.ofEpochDay(randomDay); | |||
| case TIME: | |||
| long totalMicrosInDay = ChronoUnit.DAYS.getDuration().toMillis() * 1000; | |||
| long randomTimeInMicros = ThreadLocalRandom.current().nextLong(totalMicrosInDay); | |||
| return randomTimeInMicros; | |||
| return ThreadLocalRandom.current().nextLong(totalMicrosInDay); | |||
There was a problem hiding this comment.
Should we just use RANDOM here instead of ThreadLocalRandom?
There was a problem hiding this comment.
It doesn't have method to generate long in range, now moved to generating double and used multiplier.
| return icebergDataHelper.getTableSchema().columns().stream() | ||
| .map(Types.NestedField::name) | ||
| .filter(name -> !name.equals("timestamp_local_micros_nullable_field")) |
There was a problem hiding this comment.
can we check if there is a way for Hudi to read this back as the logical type? Do the values read back as timestamps in Delta?
There was a problem hiding this comment.
For hudi there is a bug, linked in the comments and it doesn't work for Delta too and I see spark 3.2 has no support for that granularity and coverting to TimestampType doesn't work on the read side (throws errors in parquet read).
the-other-tim-brown
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Read
What is the purpose of the pull request
Brief change log
Verify this pull request
(Please pick either of the following options)
This change added tests and can be verified as follows: