Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postrun plugin #54

Merged
merged 12 commits into from
Jun 30, 2023
Merged

Add postrun plugin #54

merged 12 commits into from
Jun 30, 2023

Conversation

sebbASF
Copy link
Contributor

@sebbASF sebbASF commented Jun 8, 2023

It would be useful to be able to run shell code at the end of a run.
For example, running pagefind

Note: the code is currently implemented by a separate plugin (asfpostrun), but it could be merged with asfrun.

sebbASF added a commit to apache/www-site that referenced this pull request Jun 13, 2023
@sebbASF sebbASF requested a review from raboof June 19, 2023 08:39
@sebbASF
Copy link
Contributor Author

sebbASF commented Jun 19, 2023

This is intended for use with pagefind, which is a solution to
apache/www-site#52

@gstein
Copy link
Member

gstein commented Jun 27, 2023

I think we "should" integrate this into asfrun.py rather than construct a new plugin. Running a script during init or final ought to be the same thing, but merely "when".

@sebbASF
Copy link
Contributor Author

sebbASF commented Jun 28, 2023

I think this is now ready for merging

@clambertus clambertus requested a review from gstein June 29, 2023 17:13
@gstein gstein merged commit cf38f14 into master Jun 30, 2023
1 of 5 checks passed
@sebbASF sebbASF deleted the postrun branch June 30, 2023 20:28
@sebbASF sebbASF restored the postrun branch June 30, 2023 20:29
@sebbASF sebbASF deleted the postrun branch June 30, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants