Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][TubeMQ] Optimize redundant code in DefaultOffsetManager #5859

Closed
2 tasks done
liangyepianzhou opened this issue Sep 11, 2022 · 0 comments · Fixed by #5860
Closed
2 tasks done

[Improve][TubeMQ] Optimize redundant code in DefaultOffsetManager #5859

liangyepianzhou opened this issue Sep 11, 2022 · 0 comments · Fixed by #5860
Assignees
@liangyepianzhou
Labels
component/tubemq type/improve
Milestone
1.4.0

Comments

@liangyepianzhou
Copy link
Contributor

Description

The code duplication rate for method getAndResetTmpOffset and method setTmpOffset is as high as 90%.
In fact, method getAndResetTmpOffset can reuse method setTmpOffset.

InLong Component

InLong TubeMQ

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
@liangyepianzhou liangyepianzhou mentioned this issue Sep 11, 2022
Merged
@healchow healchow added this to the 1.4.0 milestone Sep 12, 2022
@healchow healchow changed the title [Improve][TubeMq] Optimize redundant code in DefaultOffsetManager [Improve][TubeMQ] Optimize redundant code in DefaultOffsetManager Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liangyepianzhou liangyepianzhou

Labels
component/tubemq type/improve
Projects
None yet
Milestone
1.4.0
2 participants
@healchow @liangyepianzhou