[INLONG-5859][TubeMQ] Remove the redundant codes in DefaultOffsetManager #5860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healchow
approved these changes
Sep 12, 2022
healchow
changed the title
gosonzhang
approved these changes
Sep 13, 2022
dockerzhang
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
The code duplication rate for method getAndResetTmpOffset and method setTmpOffset is as high as 90%.
In fact, method getAndResetTmpOffset can reuse method setTmpOffset.
Modifications
The code duplication rate for method getAndResetTmpOffset and method setTmpOffset is as high as 90%.
In fact, method getAndResetTmpOffset can reuse method setTmpOffset.