Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2540][Agent] Create db sql collect task by config from manager #2543

Merged
merged 3 commits into from
Feb 19, 2022

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Feb 17, 2022

Title Name: [INLONG-2540][agent] create db sql collect task by config from manager

Fixes #2540

Motivation

create db sql collect task by config from manager

Modifications

  1. change the source of SqlJobProfileDto from TextFileSource to DataBaseSource
  2. add sql struct in SqlJobProfileDto.Job

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@healchow healchow changed the title [INLONG-2540][agent] create db sql collect task by config from manager [INLONG-2540][Agent] Create db sql collect task by config from manager Feb 18, 2022
@dockerzhang dockerzhang merged commit 99a9979 into apache:master Feb 19, 2022
@justinwwhuang justinwwhuang deleted the develop2540 branch June 6, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[agent] create db sql collect task by config from manager
4 participants