Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-3883][Manager] Support create table of ClickHouse #4004

Merged
merged 10 commits into from
May 11, 2022
Merged

[INLONG-3883][Manager] Support create table of ClickHouse #4004

merged 10 commits into from
May 11, 2022

Conversation

lucaspeng12138
Copy link
Contributor

@lucaspeng12138 lucaspeng12138 commented Apr 28, 2022 •
edited by dockerzhang

Title Name: [INLONG-3883][Manager]Support create table with clickhouse

Add create table to Manager Group.

fix #3883

@lucaspeng12138 lucaspeng12138 force-pushed the dev-lucas-clickhouse branch 2 times, most recently from 2762934 to 9b6ac7a Compare April 28, 2022 08:49
@healchow healchow changed the title [INLONG-3883][Manager]Support create table with clickhouse [INLONG-3883][Manager] Support create table of ClickHouse Apr 28, 2022
@gong
Copy link
Contributor

gong commented Apr 28, 2022

git rebase master before pull request.

@lucaspeng12138 lucaspeng12138 changed the title [INLONG-3883][Manager] Support create table of ClickHouse [INLONG-3883][Manager][WIP] Support create table of ClickHouse Apr 28, 2022
@healchow healchow force-pushed the master branch 2 times, most recently from 0c056bb to dd0d942 Compare April 28, 2022 11:39
@lucaspeng12138 lucaspeng12138 marked this pull request as draft April 28, 2022 12:36
@lucaspeng12138 lucaspeng12138 changed the title [INLONG-3883][Manager][WIP] Support create table of ClickHouse [INLONG-3883][Manager] Support create table of ClickHouse Apr 28, 2022
@lucaspeng12138 lucaspeng12138 force-pushed the dev-lucas-clickhouse branch 3 times, most recently from b4559c0 to 97ef6c0 Compare April 28, 2022 12:59
@lucaspeng12138 lucaspeng12138 force-pushed the dev-lucas-clickhouse branch 3 times, most recently from 4676488 to bce1f1a Compare April 29, 2022 07:16
@dockerzhang dockerzhang marked this pull request as ready for review April 29, 2022 07:28
healchow
healchow approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@healchow healchow merged commit 5b97eee into apache:master May 11, 2022
@lucaspeng12138 lucaspeng12138 deleted the dev-lucas-clickhouse branch July 19, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosonzhang gosonzhang gosonzhang approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@EMsnap EMsnap EMsnap approved these changes

@healchow healchow healchow approved these changes

Assignees

@lucaspeng12138 lucaspeng12138

Labels
component/manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Manager] Support create table of ClickHouse
6 participants
@lucaspeng12138 @gong @gosonzhang @dockerzhang @EMsnap @healchow