Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-5650][Manager] Remove the non-null check of the Pulsar adminURL #5651

Merged
merged 1 commit into from
Aug 23, 2022
Merged

[INLONG-5650][Manager] Remove the non-null check of the Pulsar adminURL #5651

merged 1 commit into from
Aug 23, 2022

Conversation

healchow
Copy link
Member

Prepare a Pull Request

Motivation

Remove the non-null check of the Pulsar adminURL.

yunqingmoswu
yunqingmoswu approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@yunqingmoswu yunqingmoswu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@healchow healchow merged commit 8f26932 into apache:master Aug 23, 2022
dockerzhang pushed a commit that referenced this pull request Aug 23, 2022
@healchow @dockerzhang
[INLONG-5650][Manager] Remove the non-null check of the Pulsar adminU…
38dfe73 
…RL (#5651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woofyzhao woofyzhao woofyzhao approved these changes

@GanfengTan GanfengTan GanfengTan approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@EMsnap EMsnap EMsnap approved these changes

@yunqingmoswu yunqingmoswu yunqingmoswu approved these changes

Assignees
No one assigned
Labels
component/manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Remove the non-null check of the Pulsar adminURL
6 participants
@healchow @woofyzhao @GanfengTan @dockerzhang @EMsnap @yunqingmoswu