Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-6026][Audit] Fix the executed error of ClickHouse audit SQL file #6029

Merged
merged 1 commit into from
Sep 28, 2022
Merged

[INLONG-6026][Audit] Fix the executed error of ClickHouse audit SQL file #6029

merged 1 commit into from
Sep 28, 2022

Conversation

ciscozhou
Copy link
Contributor

@ciscozhou ciscozhou commented Sep 26, 2022 •
edited

Prepare a Pull Request

Motivation

ClickHouse not support those operations, remove them.

SET NAMES utf8mb4;
SET FOREIGN_KEY_CHECKS = 0;
SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO";
SET time_zone = "+00:00";

Verifying this change

  • This change is a trivial rework/code cleanup without any test coverage.

luchunliang
luchunliang approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@luchunliang luchunliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

baomingyu
baomingyu approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@baomingyu baomingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang merged commit 7f932ae into apache:master Sep 28, 2022
@ciscozhou ciscozhou deleted the INLONG-6026 branch October 6, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baomingyu baomingyu baomingyu approved these changes

@luchunliang luchunliang luchunliang approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@healchow healchow healchow approved these changes

Assignees
No one assigned
Labels
component/audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][Audit] SQL file executed error for ClickHouse in Audit
5 participants
@ciscozhou @baomingyu @luchunliang @dockerzhang @healchow