Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-6296][Sort] Split one record to multiple records when the physical data has more records for KafkaLoadNode #6298

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

yunqingmoswu
Copy link
Contributor

Prepare a Pull Request

(Change the title refer to the following example)

Title: [INLONG-6296][Sort] Split one record to multiple records when the physical data has more records for KafkaLoadNode

(The following XYZ should be replaced by the actual GitHub Issue number)

Fixes #6296

Motivation

Split one record to multiple records when the physical data has more records for KafkaLoadNode
It is only used for multiple sink scenario, for example, the raw data is:

    "data":[
        {
            "id":352,
            "price":1.14,
            "currency":"US",
            "order_time":"2022-08-16 18:59:09"
        },
        {
            "id":353,
            "price":1.22,
            "currency":"US",
            "order_time":"2022-08-16 18:59:09"
        }
    ],
    "type":"INSERT",
    "pkNames":[
        "id"
    ],
    "database":"inlong",
    "ts":1666772931248,
    "table":"orders"
}

and then it will be split into two records when writing as follows:

{
    "data":[
        {
            "id":352,
            "price":1.14,
            "currency":"US",
            "order_time":"2022-08-16 18:59:09"
        }
    ],
    "type":"INSERT",
    "pkNames":[
        "id"
    ],
    "database":"inlong",
    "ts":1666772931248,
    "table":"orders"
}
{
    "data":[
        {
            "id":353,
            "price":1.22,
            "currency":"US",
            "order_time":"2022-08-16 18:59:09"
        }
    ],
    "type":"INSERT",
    "pkNames":[
        "id"
    ],
    "database":"inlong",
    "ts":1666772931248,
    "table":"orders"
}

Modifications

  1. Add split and serializeForList handle for DynamicKafkaSerializationSchema
  2. Add serializeForList for FlinkKafkaProducer
  3. Update the visibility for ObjectMapper of JsonDynamicSchemaFormat

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

…sical data has more records for KafkaLoadNode
@healchow healchow merged commit 8fddb1d into apache:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Sort] Split one record to multiple records when the physical data has more records for KafkaLoadNode
5 participants