Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-6373][Sort] Fix the time value when data type is datetime and timestamp #6403

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

EMsnap
Copy link
Contributor

@EMsnap EMsnap commented Nov 4, 2022

Motivation

fix time value when data type is datetime and timestamp

Modifications

fix time value when data type is datetime and timestamp

For timestamp, the debezium will first get the timestamp in the database time zone, and then convert it into UTC time zone.
So we only need to convert the timestamp in UTC time zone back to its origin timestamp

For zoned time stamp, we need to convert the zone time stamp using time zone set by user and the reformat the zoned timestamp into a timestamp ended with Z since flink JsonToRowDataConverters can only parse a zoned timestamp ended with UTC "Z" time zone.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@healchow healchow changed the title [INLONG-6373][Sort] fix time value when data type is datetime and timestamp [INLONG-6373][Sort] Fix the time value when data type is datetime and timestamp Nov 4, 2022
@healchow healchow merged commit 3124201 into apache:master Nov 4, 2022
@EMsnap EMsnap deleted the 6373 branch May 30, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Sort] The time value is wrong when the data type is datetime and timestamp
3 participants