-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-7075][Sort] Add table level metric for PostgreSQL #7078
Conversation
} else if (fieldArray.length == 2) { | ||
sinkMetricData.outputMetricsWithEstimate(fieldArray[0], null, fieldArray[1], | ||
false, rowSize, dataSize); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the forms of the string before cutting? Can you give some examples?
In addition, if the array length is neither 2 nor 3, should you print logs to record data information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executed too many times here. Has log elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't understand where the log was printed? If the length of the table name string after splitting is not as expected, printing the log is very helpful for locating the problem.
1、lost dirty data metric restore public void open(int taskNumber, int numTasks) throws IOException {
this.runtimeContext = getRuntimeContext();
MetricOption metricOption = MetricOption.builder()
.withInlongLabels(inlongMetric)
.withInlongAudit(auditHostAndPorts)
.withInitRecords(metricState != null ? metricState.getMetricValue(NUM_RECORDS_OUT) : 0L)
.withInitBytes(metricState != null ? metricState.getMetricValue(NUM_BYTES_OUT) : 0L)
.withRegisterMetric(MetricOption.RegisteredMetric.ALL) 2、lost dirty data metric computing |
Prepare a Pull Request
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation