Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-7083][Sort] StarRocks connector supports dirty data archives and metric #7085

Merged
merged 11 commits into from
Dec 29, 2022

Conversation

liaorui
Copy link
Contributor

@liaorui liaorui commented Dec 28, 2022

Prepare a Pull Request

Motivation

StarRocks connector supports dirty data archives

Modifications

  1. StarRocksDynamicTableSinkFactory.java has new DirtyOptions, DirtySink and DirtySinkHelper objects.
  2. StarRocksDynamicTableSink.java, StarRocksDynamicSinkFunction.java and StarRocksSinkManager.java get DirtySinkHelper tool from StarRocksDynamicTableSinkFactory one by one.
  3. StarRocksSinkManager.java uses DirtySinkHelper to write dirty data and upload dirty data metrics when catching exceptions.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@gong
Copy link
Contributor

gong commented Dec 28, 2022

lost dirty data metric init in inlong-sort/sort-connectors/starrocks/src/main/java/org/apache/inlong/sort/starrocks/table/sink/StarRocksDynamicSinkFunction.java

  MetricOption metricOption = MetricOption.builder().withInlongLabels(inlongMetric)
                .withInlongAudit(auditHostAndPorts)
                .withInitRecords(metricState != null ? metricState.getMetricValue(NUM_RECORDS_OUT) : 0L)
                .withInitBytes(metricState != null ? metricState.getMetricValue(NUM_BYTES_OUT) : 0L)
                .withRegisterMetric(MetricOption.RegisteredMetric.ALL).build();

@gong gong changed the title [INLONG-7083][Sort]StarRocks connector supports dirty data archives [INLONG-7083][Sort] StarRocks connector supports dirty data archives and metric Dec 28, 2022
@liaorui
Copy link
Contributor Author

liaorui commented Dec 29, 2022

done

@gong gong merged commit ca6952e into apache:master Dec 29, 2022
kuansix pushed a commit to kuansix/inlong that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] StarRocks connector supports dirty data archives and metric
4 participants