-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-7083][Sort] StarRocks connector supports dirty data archives and metric #7085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lost dirty data metric init in inlong-sort/sort-connectors/starrocks/src/main/java/org/apache/inlong/sort/starrocks/table/sink/StarRocksDynamicSinkFunction.java MetricOption metricOption = MetricOption.builder().withInlongLabels(inlongMetric)
.withInlongAudit(auditHostAndPorts)
.withInitRecords(metricState != null ? metricState.getMetricValue(NUM_RECORDS_OUT) : 0L)
.withInitBytes(metricState != null ? metricState.getMetricValue(NUM_BYTES_OUT) : 0L)
.withRegisterMetric(MetricOption.RegisteredMetric.ALL).build(); |
gong
changed the title
[INLONG-7083][Sort]StarRocks connector supports dirty data archives
[INLONG-7083][Sort] StarRocks connector supports dirty data archives and metric
Dec 28, 2022
gong
reviewed
Dec 28, 2022
...onnectors/base/src/main/java/org/apache/inlong/sort/base/metric/sub/SinkTableMetricData.java
Outdated
Show resolved
Hide resolved
gong
reviewed
Dec 28, 2022
...onnectors/base/src/main/java/org/apache/inlong/sort/base/metric/sub/SinkTableMetricData.java
Outdated
Show resolved
Hide resolved
yunqingmoswu
approved these changes
Dec 29, 2022
done |
dockerzhang
approved these changes
Dec 29, 2022
gong
approved these changes
Dec 29, 2022
kuansix
pushed a commit
to kuansix/inlong
that referenced
this pull request
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
[INLONG-7083][Sort] StarRocks connector supports dirty data archives and metric
Fixes [Feature][Sort] StarRocks connector supports dirty data archives and metric #7083
Motivation
StarRocks connector supports dirty data archives
Modifications
StarRocksDynamicTableSinkFactory.java
has new DirtyOptions, DirtySink and DirtySinkHelper objects.StarRocksDynamicTableSink.java
,StarRocksDynamicSinkFunction.java
andStarRocksSinkManager.java
getDirtySinkHelper
tool fromStarRocksDynamicTableSinkFactory
one by one.StarRocksSinkManager.java
usesDirtySinkHelper
to write dirty data and upload dirty data metrics when catching exceptions.Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation