Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-9833][Agent] Add module state to distinguish whether the module has been downloaded or installed #9834

Merged
merged 1 commit into from
Mar 18, 2024
Merged

[INLONG-9833][Agent] Add module state to distinguish whether the module has been downloaded or installed #9834

merged 1 commit into from
Mar 18, 2024

Conversation

justinwwhuang
Copy link
Contributor

[INLONG-9833][Agent] Add module state to distinguish whether the module has been downloaded or installed

Motivation

Add module state to distinguish whether the module has been downloaded or installed

Modifications

Add module state to distinguish whether the module has been downloaded or installed

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@justinwwhuang justinwwhuang added this to the 1.12.0 milestone Mar 17, 2024
@justinwwhuang justinwwhuang self-assigned this Mar 17, 2024
aloyszhang
aloyszhang approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang
Copy link
Contributor

what does the module mean in the installer?

@justinwwhuang
Copy link
Contributor Author

what does the module mean in the installer?

Identify whether the current module is in a new, downloaded, or installed state

@dockerzhang dockerzhang merged commit fd95e72 into apache:master Mar 18, 2024
10 checks passed
@justinwwhuang justinwwhuang deleted the b9833 branch March 18, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@EMsnap EMsnap EMsnap approved these changes

@aloyszhang aloyszhang aloyszhang approved these changes

@haifxu haifxu Awaiting requested review from haifxu

Assignees

@justinwwhuang justinwwhuang

Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Add module state to distinguish whether the module has been downloaded or installed
4 participants
@justinwwhuang @dockerzhang @EMsnap @aloyszhang