[IOTDB-4633] Fix bugs of longToBytes in BytesUtils of tsfile #7669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTHou
reviewed
Oct 24, 2022
| @@ -523,7 +523,7 @@ public static void longToBytes(long srcNum, byte[] result, int pos, int width) { | |||
| width -= m; | |||
| int mask = 1 << (8 - cnt); | |||
| cnt += m; | |||
| byte y = (byte) (srcNum >> width); | |||
| byte y = (byte) (srcNum >>> width); | |||
There was a problem hiding this comment.
Add a UT for this bug?
Besides, intToBytes seems have a same bug...
There was a problem hiding this comment.
The UT tests for this bug have been added.
HTHou
approved these changes
Oct 28, 2022
qiaojialin
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I have met a problem of "unequal value after bytes transformation by BytesUtils in tsfile" as mentioned in IOTDB-4633. After modifying the right arithmetic shift (算术右移) to right logical shift (逻辑右移) in longToBytes function of BytesUtils in tsfile, the problem has been solved successfully.