Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOTDB-4633] Fix bugs of longToBytes in BytesUtils of tsfile #7669

Merged
merged 3 commits into from
Oct 28, 2022
Merged

[IOTDB-4633] Fix bugs of longToBytes in BytesUtils of tsfile #7669

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fece63
Fix bugs of longToBytes in BytesUtils of tsfile.
FrankHWD Oct 20, 2022
55b7427
Add tests of bytesToLong.
FrankHWD Oct 27, 2022
e15a69f
Solve bugs of intToBytes.
FrankHWD Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsfile/src/main/java/org/apache/iotdb/tsfile/utils/BytesUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ public static void longToBytes(long srcNum, byte[] result, int pos, int width) {
width -= m;
int mask = 1 << (8 - cnt);
cnt += m;
byte y = (byte) (srcNum >> width);
byte y = (byte) (srcNum >>> width);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a UT for this bug?

Besides, intToBytes seems have a same bug...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UT tests for this bug have been added.

y = (byte) (y << (8 - cnt));
mask = ~(mask - (1 << (8 - cnt)));
result[index] = (byte) (result[index] & mask | y);
Expand Down