JAMES-2586 Postgres - Guice binding EventDTO for DLP Configuration, Quota #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vttranlina
force-pushed
the
fixEventDTOModule
branch
from
c760977
to
29a8f36
Compare
|
You duplicated the quota dto related classes to quota-mailing module, you didnt move them :) |
vttranlina
force-pushed
the
fixEventDTOModule
branch
from
01f8b26
to
0f4115b
Compare
updated the commit message |
|
Why duplicating and not moving them making it generic to implems? It's DTOs... |
as discussed, the "duplicating" commit for postgres, that help us quickly fix the guice binding issue. |
|
refactored cassandra-quota-mailing in last commit |
Arsnael
approved these changes
Mar 28, 2024
…cassandra to quota-mailing module
…d classes from quota-mailing module
…ng Tran 10 minutes ago
|
squash fixup |
vttranlina
force-pushed
the
fixEventDTOModule
branch
from
f30c174
to
f498f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve linagora#5144